Hi,
On 2017년 11월 04일 12:38, Bjorn Andersson wrote:
> Propagate the error of devfreq_add_device() in devm_devfreq_add_device()
> rather than statically returning ENOMEM. This makes it slightly faster
> to pinpoint the cause of a returned error.
>
> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org>
> ---
> drivers/devfreq/devfreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 78fb496ecb4e..99c4021fc33b 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -737,7 +737,7 @@ struct devfreq *devm_devfreq_add_device(struct device
> *dev,
> devfreq = devfreq_add_device(dev, profile, governor_name, data);
> if (IS_ERR(devfreq)) {
> devres_free(ptr);
> - return ERR_PTR(-ENOMEM);
> + return devfreq;
> }
>
> *ptr = devfreq;
>
Looks good to me.
Acked-by: Chanwoo Choi <cw00.c...@samsung.com>
But, you better to send this patch to the 'sta...@vger.kernel.org'
with the fixes information as following:
Fixes: 8cd84092d35e ("PM / devfreq: Add resource-managed function for devfreq
device")
Cc: sta...@vger.kernel.org
Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
