Hi Viresh, Rafael, Without this patch, schedutil is totally broken for us - is there any chance at all this could go in 4.14 or is it just too late?
Best Regards, Chris On 03/11/17 15:45, Viresh Kumar wrote:
On 03-11-17, 13:36, Chris Redpath wrote:After 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks") We stopped always reading utilization for the cpu we are running the governor on, and instead read it for the cpu which we've been told has updated utilization. This is stored in sugov_cpu->cpu. The value is set in sugov_register but we clear it in sugov_start which leads to always looking at the utilization of CPU0 instead of the correct one. Let's fix this by consolidating the initialization code into sugov_start(). Fixes: 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks") Signed-off-by: Chris Redpath <[email protected]> Reviewed-by: Patrick Bellasi <[email protected]> Reviewed-by: Brendan Jackman <[email protected]> Cc: Rafael J. Wysocki <[email protected]> Cc: Viresh Kumar <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Peter Zijlstra <[email protected]> --- kernel/sched/cpufreq_schedutil.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)Acked-by: Viresh Kumar <[email protected]>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
