On 06/11/17 05:36, Zhao Qiang wrote: > move the driver from drivers/soc/fsl/qe to drivers/irqchip, > merge qe_ic.h and qe_ic.c into irq-qeic.c. > > Signed-off-by: Zhao Qiang <qiang.z...@nxp.com> > --- > MAINTAINERS | 6 ++ > drivers/irqchip/Makefile | 1 + > drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} | 95 ++++++++++++++++++- > drivers/soc/fsl/qe/Makefile | 2 +- > drivers/soc/fsl/qe/qe_ic.h | 103 > --------------------- > 5 files changed, 100 insertions(+), 107 deletions(-) > rename drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} (85%) > delete mode 100644 drivers/soc/fsl/qe/qe_ic.h In my previous review of the same patch, I asked for the single-bit constants to be rewritten as BIT(x). You've done none of that. Why?
Thanks, M. -- Jazz is not dead. It just smells funny...