On Sun, 2007-05-06 at 15:40 +0530, Satyam Sharma wrote: > Hi Tom, > > On 5/6/07, Tom Zanussi <[EMAIL PROTECTED]> wrote: > > [...] > > relay doesn't need to use schedule_delayed_work() for waking readers > > when a simple timer will do. > > > > Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]> > > [...] > > diff --git a/include/linux/relay.h b/include/linux/relay.h > > index 759a0f9..cac0732 100644 > > --- a/include/linux/relay.h > > +++ b/include/linux/relay.h > > @@ -38,7 +38,7 @@ struct rchan_buf > > size_t subbufs_consumed; /* count of sub-buffers consumed */ > > struct rchan *chan; /* associated channel */ > > wait_queue_head_t read_wait; /* reader wait queue */ > > - struct delayed_work wake_readers; /* reader wake-up work struct */ > > + struct timer_list timer; /* reader wake-up timer */ > > struct dentry *dentry; /* channel file dentry */ > > struct kref kref; /* channel buffer refcount */ > > struct page **page_array; /* array of current buffer pages */ > > I suspect you could now safely get rid of the "#include > <linux/wait.h>" at the top of relay.h too. And although timer.h comes > via #include <linux/sched.h>, you might want to do that explicitly > too. >
Hi Satyam, Thanks for your comments - I've updated the patch to include timer.h but wait.h would still be needed for wait_queue_head_t, so will leave that in. Tom - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/