Rob Thanks for the review
On 11/16/2017 09:41 AM, Rob Herring wrote: > On Wed, Nov 15, 2017 at 01:42:02PM -0600, Dan Murphy wrote: >> This adds the devicetree bindings for the LM3692x >> I2C LED string driver. >> >> Acked-by: Pavel Machek <pa...@ucw.cz> >> Signed-off-by: Dan Murphy <dmur...@ti.com> >> --- >> >> v3 - No changes >> v2 - No changes - https://patchwork.kernel.org/patch/10056677/ >> >> .../devicetree/bindings/leds/leds-lm3692x.txt | 28 >> ++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3692x.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt >> b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt >> new file mode 100644 >> index 000000000000..cfef67bd4100 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt >> @@ -0,0 +1,28 @@ >> +* Texas Instruments - LM3692x Highly Efficient Dual-String White LED Driver >> + >> +The LM36922 is an ultra-compact, highly efficient, >> +two string white-LED driver designed for LCD display >> +backlighting. >> + >> +Required properties: >> + - compatible: >> + "ti,lm3692x" > > Don't use wildcards in compatible strings. Do you mean to remove the x? How do we denote a family of parts then? > >> + - reg - I2C slave address >> + >> +Optional properties: >> + - label - Used for naming LEDs >> + - enable-gpio - gpio pin to enable/disable the device. > > enable-gpios is the preferred form. ack > >> + - supply - "vled" - LED supply > > vled-supply - ... > ack >> + >> +Example: >> + >> +leds: leds@6 { >> + compatible = "ti,lm3692x"; >> + reg = <0x36>; >> + label = "backlight_cluster"; >> + enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; >> + vled-supply = <&vbatt>; >> +} >> + >> +For more product information please see the link below: >> +http://www.ti.com/lit/ds/snvsa29/snvsa29.pdf >> -- >> 2.15.0.124.g7668cbc60 >> -- ------------------ Dan Murphy
