Commit-ID: 2f0af8600e82e9f950fc32908386b9c639f88d48 Gitweb: https://git.kernel.org/tip/2f0af8600e82e9f950fc32908386b9c639f88d48 Author: Namhyung Kim <namhy...@kernel.org> AuthorDate: Tue, 14 Nov 2017 09:15:42 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitDate: Thu, 16 Nov 2017 14:49:59 -0300
perf help: Fix a bug during strstart() conversion The commit 8e99b6d4533c changed prefixcmp() to strstart() but missed to change the return value in some place. It makes perf help print annoying output even for sane config items like below: $ perf help '.root': unsupported man viewer sub key. ... Reported-by: Arnaldo Carvalho de Melo <a...@redhat.com> Signed-off-by: Namhyung Kim <namhy...@kernel.org> Tested-by: Arnaldo Carvalho de Melo <a...@redhat.com> Tested-by: Taeung Song <treeze.tae...@gmail.com> Cc: Jiri Olsa <jo...@kernel.org> Cc: Sihyeon Jang <uneedsihy...@gmail.com> Cc: kernel-t...@lge.com Link: http://lkml.kernel.org/r/20171114001542.GA16464@sejong Fixes: 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel") Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com> --- tools/perf/builtin-help.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c index bd1fede..a0f7ed2 100644 --- a/tools/perf/builtin-help.c +++ b/tools/perf/builtin-help.c @@ -284,7 +284,7 @@ static int perf_help_config(const char *var, const char *value, void *cb) add_man_viewer(value); return 0; } - if (!strstarts(var, "man.")) + if (strstarts(var, "man.")) return add_man_viewer_info(var, value); return 0; @@ -314,7 +314,7 @@ static const char *cmd_to_page(const char *perf_cmd) if (!perf_cmd) return "perf"; - else if (!strstarts(perf_cmd, "perf")) + else if (strstarts(perf_cmd, "perf")) return perf_cmd; return asprintf(&s, "perf-%s", perf_cmd) < 0 ? NULL : s;
