On Wed, 18 Oct 2017 10:48:32 +0000 Srividya Desireddy <srividya...@samsung.com> wrote:
> +/* Enable/disable handling same-value filled pages (enabled by default) */ > +static bool zswap_same_filled_pages_enabled = true; > +module_param_named(same_filled_pages_enabled, > zswap_same_filled_pages_enabled, > + bool, 0644); Do we actually need this? Being able to disable the new feature shows a certain lack of confidence ;) I guess we can remove it later as that confidence grows. Please send a patch to document this parameter in Documentation/vm/zswap.txt. And if you have time, please check that the rest of that file is up-to-date? Thanks.