On Tue, May 08 2007, Pekka Enberg wrote:
> Hi Rene,
>
> On 5/8/07, Rene Herman <[EMAIL PROTECTED]> wrote:
> >+static int __mitsumi_read_toc(struct mitsumi_cdrom *mcd)
> >+{
> >+ int tracks = mcd->header.cdth_trk1 - mcd->header.cdth_trk0 + 1;
> >+ int retries;
> >+ int err = 0;
> >+
> >+ kfree(mcd->toc);
> >+
> >+ mcd->toc = kzalloc(tracks * sizeof *mcd->toc, GFP_KERNEL);
>
> Perhaps we should use krealloc() + memset() here?
and sizeof(*cmd->toc) as well.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
