On Tue, May 08, 2007 at 07:29:20AM -0700, Jon Loeliger wrote: > > > > - [EMAIL PROTECTED] { > > > - linux,phandle = <f8200000>; > > > + pci_pic:[EMAIL PROTECTED] { > > > > I'd like to establish a convention of putting a space after the : and > > using capitals for labels unless there's a strong reason not to in a > > particular case. It makes them easier to visually distinguish next to > > the node name. > > Colon-space is easy and I'll buy it. > I'm not big on uppercase shouting, though.
I don't think it will really be any more shouty than the convention of using caps for simple constant #defines. The Ebony device tree uses this now, and I think it turns out quite well (though in that case there's the additional reason to use caps that the labels are based on the component names used in the 440GP user manual, which are given as caps). -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/