On Tuesday 28 November 2017 05:22 PM, Mark Brown wrote:
On Tue, Nov 28, 2017 at 10:13:44AM +0530, Vijendar Mukunda wrote:- acp_init(audio_drv_data->acp_mmio, audio_drv_data->asic_type); + status = acp_init(audio_drv_data->acp_mmio, audio_drv_data->asic_type); + if (status) { + dev_err(&pdev->dev, "ACP Init failed\n"); + return status; + }Better to print the error code to help people see what went wrong.static int acp_audio_remove(struct platform_device *pdev) { + int status; struct audio_drv_data *adata = dev_get_drvdata(&pdev->dev);- acp_deinit(adata->acp_mmio);+ status = acp_deinit(adata->acp_mmio); + if (status) { + dev_err(&pdev->dev, "ACP Deinit failed\n"); + return status; + } snd_soc_unregister_platform(&pdev->dev);Remove operations can't meaningfully fail, better to just log the error and carry on.
Will prepare a patch based on your review comments and post it as V2 version.
