Re: [PATCH RFC 2/2] arm64: allwinner: a64: Add Brava Keller initial support

Maxime Ripard Thu, 30 Nov 2017 23:55:33 -0800

On Fri, Dec 01, 2017 at 12:12:14AM +0530, Jagan Teki wrote:
> Brava Keller is A64 based IoT device, which support
> - Allwinner A64 Cortex-A53
> - AXP803 PMIC
> - 1GB DDR3 RAM
> - 8GB eMMC
> - Mali-400MP2 GPU
> - AP6330 Wifi/BLE
> - Camera OV5640
> - USB Host and OTG
> 
> Signed-off-by: Jagan Teki <[email protected]>
> ---
> Note: Need to test it on hardware
>  
>  arch/arm64/boot/dts/allwinner/Makefile             |   1 +
>  .../boot/dts/allwinner/sun50i-a64-brava-keller.dts | 244 
> +++++++++++++++++++++
>  2 files changed, 245 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts
> 
> diff --git a/arch/arm64/boot/dts/allwinner/Makefile 
> b/arch/arm64/boot/dts/allwinner/Makefile
> index f505227..af80ca0 100644
> --- a/arch/arm64/boot/dts/allwinner/Makefile
> +++ b/arch/arm64/boot/dts/allwinner/Makefile
> @@ -1,5 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb
> +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-brava-keller.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts 
> b/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts
> new file mode 100644
> index 0000000..f5303a3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts
> @@ -0,0 +1,244 @@
> +/*
> + * Copyright (C) 2017 Jagan Teki <[email protected]>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This library is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This library is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +/dts-v1/;
> +
> +#include "sun50i-a64.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> +     model = "Brava Keller";
> +     compatible = "brava,brava-keller", "allwinner,sun50i-a64";
> +
> +     aliases {
> +             serial2 = &uart2;
> +     };
> +
> +     chosen {
> +             stdout-path = "serial0:115200n8";
> +     };


Same comment than on U-Boot.

> +     wifi_pwrseq: wifi_pwrseq {
> +             compatible = "mmc-pwrseq-simple";
> +             pinctrl-names = "default";
> +             reset-gpios = <&pio 0 2 GPIO_ACTIVE_LOW>; /* WL-PMU-EN: PL2 */
> +             post-power-on-delay-ms = <200>;
> +     };
> +};
> +
> +&ehci0 {
> +     status = "okay";
> +};
> +
> +&ehci1 {
> +     status = "okay";
> +};
> +
> +&mmc1 {
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&mmc1_pins>;
> +     vmmc-supply = <&reg_dcdc1>;
> +     vqmmc-supply = <&reg_dldo4>;
> +     mmc-pwrseq = <&wifi_pwrseq>;
> +     bus-width = <4>;
> +     non-removable;
> +     status = "okay";
> +
> +     brcmf: wifi@1 {
> +             reg = <1>;
> +             compatible = "brcm,bcm4329-fmac";
> +             interrupt-parent = <&r_pio>;
> +             interrupts = <0 7 IRQ_TYPE_LEVEL_LOW>;  /* WL-WAKE-AP: PL3 */
> +             interrupt-names = "host-wake";
> +     };
> +};
> +
> +&mmc2 {
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&mmc2_pins>;
> +     vmmc-supply = <&reg_dcdc1>;

You probably have a vqmmc tosetup too.

> +     bus-width = <8>;
> +     non-removable;
> +     cap-mmc-hw-reset;
> +     status = "okay";
> +};
> +
> +&ohci0 {
> +     status = "okay";
> +};
> +
> +&ohci1 {
> +     status = "okay";
> +};
> +
> +&r_rsb {
> +     status = "okay";
> +
> +     axp803: pmic@3a3 {
> +             compatible = "x-powers,axp803";
> +             reg = <0x3a3>;
> +             interrupt-parent = <&r_intc>;
> +             interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +     };
> +};
> +
> +#include "axp803.dtsi"
> +
> +&reg_aldo1 {
> +     regulator-always-on;
> +     regulator-min-microvolt = <1800000>;
> +     regulator-max-microvolt = <3300000>;
> +     regulator-name = "avdd-csi";
> +};
> +
> +&reg_aldo2 {
> +     regulator-always-on;
> +     regulator-min-microvolt = <1800000>;
> +     regulator-max-microvolt = <1800000>;
> +     regulator-name = "vcc-pl";
> +};
> +
> +&reg_aldo3 {
> +     regulator-always-on;
> +     regulator-min-microvolt = <3000000>;
> +     regulator-max-microvolt = <3000000>;
> +     regulator-name = "vcc-pll-avcc";
> +};
> +
> +&reg_dcdc1 {
> +     regulator-always-on;
> +     regulator-min-microvolt = <3300000>;
> +     regulator-max-microvolt = <3300000>;
> +     regulator-name = "vcc-3v3";
> +};
> +
> +&reg_dcdc2 {
> +     regulator-always-on;
> +     regulator-min-microvolt = <1040000>;
> +     regulator-max-microvolt = <1300000>;
> +     regulator-name = "vdd-cpux";
> +};
> +
> +/* DCDC3 is polyphased with DCDC2 */
> +
> +&reg_dcdc5 {
> +     regulator-always-on;
> +     regulator-min-microvolt = <1500000>;
> +     regulator-max-microvolt = <1500000>;
> +     regulator-name = "vcc-dram";
> +};
> +
> +&reg_dcdc6 {
> +     regulator-always-on;
> +     regulator-min-microvolt = <1100000>;
> +     regulator-max-microvolt = <1100000>;
> +     regulator-name = "vdd-sys";
> +};
> +
> +&reg_dldo1 {
> +     regulator-min-microvolt = <3300000>;
> +     regulator-max-microvolt = <3300000>;
> +     regulator-name = "vcc-hdmi-dsi-sensor";
> +};
> +
> +&reg_dldo2 {
> +     regulator-min-microvolt = <3300000>;
> +     regulator-max-microvolt = <3300000>;
> +     regulator-name = "vcc-mipi";
> +};
> +
> +&reg_dldo3 {
> +     regulator-min-microvolt = <2800000>;
> +     regulator-max-microvolt = <2800000>;
> +     regulator-name = "vcc-gen";
> +};
> +
> +&reg_dldo4 {
> +     regulator-min-microvolt = <3300000>;
> +     regulator-max-microvolt = <3300000>;
> +     regulator-name = "vcc-wifi-io";
> +};
> +
> +&reg_eldo1 {
> +     regulator-min-microvolt = <1800000>;
> +     regulator-max-microvolt = <1800000>;
> +     regulator-name = "cpvdd";
> +};
> +
> +&reg_fldo1 {
> +     regulator-min-microvolt = <1200000>;
> +     regulator-max-microvolt = <1200000>;
> +     regulator-name = "vcc-1v2-hsic";
> +};
> +
> +/*
> + * The A64 chip cannot work without this regulator off, although
> + * it seems to be only driving the AR100 core.
> + * Maybe we don't still know well about CPUs domain.
> + */
> +&reg_fldo2 {
> +     regulator-always-on;
> +     regulator-min-microvolt = <1100000>;
> +     regulator-max-microvolt = <1100000>;
> +     regulator-name = "vdd-cpus";
> +};
> +
> +&reg_rtc_ldo {
> +     regulator-name = "vcc-rtc";
> +};
> +
> +&uart1 {
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
> +     status = "okay";
> +};

I guess this is a BT device, please use the serdev binding here.

> +&uart2 {
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&uart2_pins>;
> +     status = "okay";
> +};
> +
> +&usbphy {
> +     status = "okay";

And please tie in the regulators here.

> +};
> -- 
> 2.7.4
> 

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

signature.asc
Description: PGP signature

Re: [PATCH RFC 2/2] arm64: allwinner: a64: Add Brava Keller initial support

Reply via email to