This is not required.
Looking with dmidecode, Glimmer reports:
...
BIOS Information
Vendor: coreboot
Version: Google_Glimmer.5216.198.19
...
Therefore, the first entry of cros_ec_lpc_dmi_table will match.
Gwendal.
On Fri, Dec 1, 2017 at 5:42 AM, Thierry Escande
<[email protected]> wrote:
> This patch adds device information to the DMI table of the cros_ec_lpc
> driver for Google Glimmer devices. Since Google BIOS does not enumerate
> devices in the LPC bus, the cros_ec_lpc driver checks for system
> compatibility and registers the cros_ec device itself.
>
> Signed-off-by: Thierry Escande <[email protected]>
> ---
> drivers/platform/chrome/cros_ec_lpc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_lpc.c
> b/drivers/platform/chrome/cros_ec_lpc.c
> index 0b26a09..4a2fc55 100644
> --- a/drivers/platform/chrome/cros_ec_lpc.c
> +++ b/drivers/platform/chrome/cros_ec_lpc.c
> @@ -365,6 +365,13 @@ static const struct dmi_system_id
> cros_ec_lpc_dmi_table[] __initconst = {
> DMI_MATCH(DMI_PRODUCT_NAME, "Peppy"),
> },
> },
> + {
> + /* x86-glimmer, the Lenovo Thinkpad Yoga 11e. */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Glimmer"),
> + },
> + },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(dmi, cros_ec_lpc_dmi_table);
> --
> 2.7.4
>
