On Sun, 2017-11-12 at 22:04 +0100, Hans-Frieder Vogt wrote: > Hi, hi back.
> attached is the revised version of a driver that supports the serial OneWire > masters from iButtonLink(TM) in the w1 kernel driver. In order to be usable > it needs an updated userland tool (patch included in documentation file). The > kernel patch is against linux-next. Please try and comment. > > v2 of the patch set changes the following: > - based on review input from Evgeniy (thanks!), introduced a helper function > to re-use more code and generally improved the style of the code (couldn't > get rid of all problems checkpatch identified, but many of them) > - introduced a version check to make sure the hardware belongs to the > supported devices > - removed a dependency on little endian system > - further testing revealed re-entry problems. The protection of critical code > areas has therefore been changed from local spinlocks to a more toplevel > mutex-based system to enforce serialisation. I have not run into any problems > with unexpected feedback from the link device since. Please wrap your commit messages. A maximum line length at 72 or so is preferred. > Signed-off by: Hans-Frieder Vogt <hfv...@gmx.net> Note the space between off and by. checkpatch does correctly warn about this as "missing Signed-off-by:" Not much can be done to quiet checkpatch when the patches contain an inter-diff.
