James Morris <james.l.mor...@oracle.com> wrote:
> I think a general cleanup in that function to make all of these follow the
> pattern:
>
> if (something) {
> key_ref = ERR_PTR(-error);
> goto error;
> }
>
> rather than unconditionally setting the error first, would be better, but
> this is a clear enough fix on its own.
There's a preference in Linux to use:
key_ref = ERR_PTR(-error);
if (something)
goto error;
instead because it uses less vertical space. It might originally have been
promulgated by Linus, but I don't remember. Though you do have a point - your
way makes error handling less subject breakage from code rearrangement.
David
