On 11/29/2017 04:19 PM, SF Markus Elfring wrote: >>> It's pretty unlikely, but it is an actual defect. >> >> No it is not, those variables will never be set to NULL, >> so this can never be triggered. Walk up the call chain. > > If the involved software developers are convinced about the validity > of this pointer: > > How do you think about to delete the following condition check > instead in the discussed function implementations? > > if (!ch) > return; > > > Regards, > Markus >
Thanks for the fix. I was on vacation - but now seeing all the analysis made here, if "ch" can't be NULL then please go ahead and remove the check =) I observed that this check comes from before Git, so really ancient code... Cheers, Guilherme
