On 12/05/2017 08:09 AM, [email protected] wrote: > From: Julien BOIBESSOT <[email protected]> > > Fixes following build error: > vhci_driver.c: In function 'refresh_imported_device_list': > vhci_driver.c:118:37: error: 'snprintf' output may be truncated before > the last format character [-Werror=format-truncation=] > snprintf(status, sizeof(status), "status.%d", i); > ^~~~~~~~~~~ > vhci_driver.c:118:4: note: 'snprintf' output between 9 and 18 bytes into > a destination of size 17 > snprintf(status, sizeof(status), "status.%d", i); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Signed-off-by: Julien BOIBESSOT <[email protected]> > --- > tools/usb/usbip/libsrc/vhci_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/usb/usbip/libsrc/vhci_driver.c > b/tools/usb/usbip/libsrc/vhci_driver.c > index 5727dfb..a9ce431 100644 > --- a/tools/usb/usbip/libsrc/vhci_driver.c > +++ b/tools/usb/usbip/libsrc/vhci_driver.c > @@ -106,7 +106,7 @@ static int parse_status(const char *value) > return 0; > } > > -#define MAX_STATUS_NAME 16 > +#define MAX_STATUS_NAME 18 > > static int refresh_imported_device_list(void) > { >
I have been thinking about this some and if it indeed a large ncontrollers value that makes the buffer overflow, we might have a bigger problem. That said, this patch looks good to fix the warming. Greg, Could you please pick this patch up. Acked-by: Shuah Khan <[email protected]> thanks, -- Shuah
