From: Markus Elfring <[email protected]> Date: Thu, 7 Dec 2017 21:55:09 +0100
Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> --- drivers/tty/serial/sccnxp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/sccnxp.c b/drivers/tty/serial/sccnxp.c index d6ae3086c2a2..ba1653ba5f37 100644 --- a/drivers/tty/serial/sccnxp.c +++ b/drivers/tty/serial/sccnxp.c @@ -857,10 +857,9 @@ static int sccnxp_probe(struct platform_device *pdev) return PTR_ERR(membase); s = devm_kzalloc(&pdev->dev, sizeof(struct sccnxp_port), GFP_KERNEL); - if (!s) { - dev_err(&pdev->dev, "Error allocating port structure\n"); + if (!s) return -ENOMEM; - } + platform_set_drvdata(pdev, s); spin_lock_init(&s->lock); -- 2.15.1
