On 11.12.2017 16:53, Dmitry Osipenko wrote: > On 11.12.2017 13:13, Thierry Reding wrote: >> On Mon, Dec 11, 2017 at 02:19:44AM +0300, Dmitry Osipenko wrote: >>> Add manual HW power management to drivers probe/remove in order to >>> not fail in a case of runtime power management being disabled in kernel >>> config. >>> >>> Signed-off-by: Dmitry Osipenko <dig...@gmail.com> >>> --- >>> drivers/gpu/drm/tegra/dc.c | 164 >>> +++++++++++++++++++++++++++---------------- >>> drivers/gpu/drm/tegra/dsi.c | 138 +++++++++++++++++++++--------------- >>> drivers/gpu/drm/tegra/hdmi.c | 90 ++++++++++++++++-------- >>> drivers/gpu/drm/tegra/sor.c | 103 +++++++++++++++++---------- >>> 4 files changed, 310 insertions(+), 185 deletions(-) >> >> I think that's the wrong way around. We unconditionally select PM on >> 64-bit ARM already, and I think we should do the same on 32-bit ARM. >> There's really no excuse not to enable runtime PM these days. > > What is the rational behind enabling PM unconditionally? It is actually a very > useful debug feature when there is something wrong with the PM. It looks like > Tegra DRM driver is the only driver on Tegra that doesn't work properly with > PM > being disabled. Please, let's just fix it.
BTW, I've noticed that I sent wrong version of the patch. Will send proper in V2, of course of if you don't mind fixing the driver :)
