On Thursday, November 30, 2017 4:52 PM, Lukasz Majewski wrote:
>
> The BK3 board is a derivative of the ts72xx reference design.

Lukasz,

I was just reviewing the other TS-72xx boards and noticed this:

<snip>

> +/* BK3 specific defines */
> +#define BK3_CPLDVER_PHYS_BASE                0x23400000
> +#define BK3_CPLDVER_VIRT_BASE                0xfebfd000
> +#define BK3_CPLDVER_SIZE             0x00001000
> +

<snip>

> +static struct map_desc bk3_io_desc[] __initdata = {
> +     {
> +             .virtual        = BK3_CPLDVER_VIRT_BASE,
> +             .pfn            = __phys_to_pfn(BK3_CPLDVER_PHYS_BASE),
> +             .length = BK3_CPLDVER_SIZE,
> +             .type           = MT_DEVICE,
> +     }
> +};
> +

This register appears to be common to all the TS-72xx boards.

I don't think Arnd has pulled the series yet. Would you mind renaming the
defines and rebasing this patch? The BK3 board and other TS-72xx boards
can then have a common .map_io.

Thanks,
Hartley

Reply via email to