On Fri, 11 May 2007 14:33:46 +0200 (CEST) Jan Kratochvil <[EMAIL PROTECTED]> wrote:
> Hello, > I sent this patch 5 days ago, nobody replied. So I am giving it second > attempt. > Andrew, is it possible to test this in -mm branch? > Original mail follows: > > Hi, > this is something like reaction to this thread: > http://lkml.org/lkml/2007/1/6/124. I hope I was able to separate the PIE > randomization part correctly. > > There is platform specific (__i386__ only) part in exec shield, I am not > pretty sure why is it there, but wasn't brave enough to touch it. Can > someone comment the #ifdef out and test it on some other platform? > > It will be nice to follow with brk randomization, but in exec-shield it is > afaik i386 only. Right? > > Randomizes -pie compiled binaries. The implementation is part of Redhat's > exec-shield (http://people.redhat.com/mingo/exec-shield/). > I don't know what to do with this. The changelog doesn't tell me what PIE randomization _is_, nor why the kernel would want to do it. "Randomizing -pie compiled binaries" sounds fairly undesirable, actually ;) > > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c > index 9cc4f0a..1156f41 100644 > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -45,7 +45,7 @@ > > static int load_elf_binary(struct linux_binprm *bprm, struct pt_regs > *regs); > static int load_elf_library(struct file *); > -static unsigned long elf_map (struct file *, unsigned long, struct elf_phdr > *, int, int); > +static unsigned long elf_map (struct file *, unsigned long, struct elf_phdr > *, int, int, unsigned long); Your email client is space-stuffing the patches. That's easy to fix at the receiving end, but it'd be better to fix it at the sending end, please. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/