2017-12-13 15:54 GMT+01:00 Andy Shevchenko <andy.shevche...@gmail.com>: > On Wed, Dec 13, 2017 at 11:28 AM, Bartosz Golaszewski <b...@bgdev.pl> wrote: >> User space can initiate concurrent access to regmap over debugfs and, >> if the locking is disabled, we can't protect it. Don't create the >> debugfs entries at all in this case. >> >> Suggested-by: Lars-Peter Clausen <l...@metafoo.de> >> Signed-off-by: Bartosz Golaszewski <b...@bgdev.pl> > >> + dev_dbg(map->dev, "locking disabled - not creating debugfs >> entries\n"); > > I dunno about level (OK debug seems good because we are still talking > about debug), though message might be slightly confusing (if driver > itself is using debugfs for its own purposes), so, I would suggest to > add > "regmap: locking...". > > -- > With Best Regards, > Andy Shevchenko
Good point, I think "regmap locking disabled..." would be even better in this case. Thanks, Bartosz
