On Wed, 13 Dec 2017 13:57:52 +0300 "Kirill A. Shutemov" <[email protected]> wrote:
> From: Nitin Gupta <[email protected]> > > It's required to avoid losing dirty and accessed bits. > > ... > > --- a/arch/sparc/include/asm/pgtable_64.h > +++ b/arch/sparc/include/asm/pgtable_64.h > @@ -1010,7 +1010,7 @@ void update_mmu_cache_pmd(struct vm_area_struct *vma, > unsigned long addr, > pmd_t *pmd); > > #define __HAVE_ARCH_PMDP_INVALIDATE > -extern void pmdp_invalidate(struct vm_area_struct *vma, unsigned long > address, > +extern pmd_t pmdp_invalidate(struct vm_area_struct *vma, unsigned long > address, > pmd_t *pmdp); > > #define __HAVE_ARCH_PGTABLE_DEPOSIT > diff --git a/arch/sparc/mm/tlb.c b/arch/sparc/mm/tlb.c > index 4ae86bc0d35c..5a3ba863b48a 100644 > --- a/arch/sparc/mm/tlb.c > +++ b/arch/sparc/mm/tlb.c > @@ -219,17 +219,28 @@ void set_pmd_at(struct mm_struct *mm, unsigned long > addr, > } > } > > +static inline pmd_t pmdp_establish(struct vm_area_struct *vma, > + unsigned long address, pmd_t *pmdp, pmd_t pmd) > +{ > + pmd_t old; > + > + { > + old = *pmdp; > + } while (cmpxchg64(&pmdp->pmd, old.pmd, pmd.pmd) != old.pmd); > + > + return old; > +} um, I think I'll put a "do" in there... And I'll wait until we see a "tested-by" or a nice ack, please.
