On Fri, Dec 15, 2017 at 6:09 AM, Christoph Hellwig <[email protected]> wrote: > From: Logan Gunthorpe <[email protected]> > > This new interface is similar to how struct device (and many others) > work. The caller initializes a 'struct dev_pagemap' as required > and calls 'devm_memremap_pages'. This allows the pagemap structure to > be embedded in another structure and thus container_of can be used. In > this way application specific members can be stored in a containing > struct. > > This will be used by the P2P infrastructure and HMM could probably > be cleaned up to use it as well (instead of having it's own, similar > 'hmm_devmem_pages_create' function). > > Signed-off-by: Logan Gunthorpe <[email protected]> > Signed-off-by: Christoph Hellwig <[email protected]>
Looks good, I notice that this does not initialize pgmap->type to MEMORY_DEVICE_HOST, but since that value is zero and likely won't change we're ok. Reviewed-by: Dan Williams <[email protected]>
