Hi Wenyou, On Tue, Dec 19, 2017 at 02:11:28AM +0000, wenyou.y...@microchip.com wrote: > Hi Sakari, > > > -----Original Message----- > > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > > Sent: 2017年12月14日 4:06 > > To: Wenyou Yang - A41535 <wenyou.y...@microchip.com>; Mauro Carvalho > > Chehab <mche...@s-opensource.com>; Rob Herring <robh...@kernel.org>; > > Mark Rutland <mark.rutl...@arm.com> > > Cc: linux-kernel@vger.kernel.org; Nicolas Ferre - M43238 > > <nicolas.fe...@microchip.com>; devicet...@vger.kernel.org; Jonathan Corbet > > <cor...@lwn.net>; Hans Verkuil <hverk...@xs4all.nl>; linux-arm- > > ker...@lists.infradead.org; Linux Media Mailing List <linux- > > me...@vger.kernel.org>; Songjun Wu <songjun...@microchip.com> > > Subject: Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver > > > > Hi Wenyou, > > > > Wenyou Yang wrote: > > ... > > > +static int ov7740_start_streaming(struct ov7740 *ov7740) { > > > + int ret; > > > + > > > + if (ov7740->fmt) { > > > + ret = regmap_multi_reg_write(ov7740->regmap, > > > + ov7740->fmt->regs, > > > + ov7740->fmt->reg_num); > > > + if (ret) > > > + return ret; > > > + } > > > + > > > + if (ov7740->frmsize) { > > > + ret = regmap_multi_reg_write(ov7740->regmap, > > > + ov7740->frmsize->regs, > > > + ov7740->frmsize->reg_num); > > > + if (ret) > > > + return ret; > > > + } > > > + > > > + return __v4l2_ctrl_handler_setup(ov7740->subdev.ctrl_handler); > > > > I believe you're still setting the controls after starting streaming. > > Yes, it sees it does so. > > The OV7740 sensor generates the stream pixel data at the constant frame > rate, no such start or stop control.
That'd be odd but I guess hardware sometimes is. I'll apply the patches. Thanks! -- Sakari Ailus e-mail: sakari.ai...@iki.fi
