Fixes checkpatch warning:

  WARNING: else is not generally useful after a break or return

Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr>
---
v5: resend patchset based on comments

 drivers/staging/pi433/pi433_if.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index b4e6094ad553..02887988d2ea 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -773,11 +773,11 @@ pi433_read(struct file *filp, char __user *buf, size_t 
size, loff_t *f_pos)
        if (device->rx_active) {
                mutex_unlock(&device->rx_lock);
                return -EAGAIN;
-       } else {
-               device->rx_active = true;
-               mutex_unlock(&device->rx_lock);
        }
 
+       device->rx_active = true;
+       mutex_unlock(&device->rx_lock);
+
        /* start receiving */
        /* will block until something was received*/
        device->rx_buffer_size = size;
@@ -1117,12 +1117,12 @@ static int pi433_probe(struct spi_device *spi)
        if (retval) {
                dev_dbg(&spi->dev, "configuration of SPI interface failed!\n");
                return retval;
-       } else {
-               dev_dbg(&spi->dev,
-                       "spi interface setup: mode 0x%2x, %d bits per word, 
%dhz max speed",
-                       spi->mode, spi->bits_per_word, spi->max_speed_hz);
        }
 
+       dev_dbg(&spi->dev,
+               "spi interface setup: mode 0x%2x, %d bits per word, %dhz max 
speed",
+               spi->mode, spi->bits_per_word, spi->max_speed_hz);
+
        /* Ping the chip by reading the version register */
        retval = spi_w8r8(spi, 0x10);
        if (retval < 0)
-- 
2.15.0

Reply via email to