On 12/20/2017 8:07 AM, Vivek Gautam wrote:
> Hi Manu,
>
> [snip]
>
>> @@ -998,29 +992,17 @@ static int qcom_qmp_phy_reset_init(struct device *dev)
>> static int qcom_qmp_phy_clk_init(struct device *dev)
>> {
>> struct qcom_qmp *qmp = dev_get_drvdata(dev);
>> - int ret, i;
>> + int num = qmp->cfg->num_clks;
>> + int i;
>>
>> - qmp->clks = devm_kcalloc(dev, qmp->cfg->num_clks,
>> - sizeof(*qmp->clks), GFP_KERNEL);
>> + qmp->clks = devm_kcalloc(dev, num, sizeof(*qmp->clks), GFP_KERNEL);
>> if (!qmp->clks)
>> return -ENOMEM;
>>
>> - for (i = 0; i < qmp->cfg->num_clks; i++) {
>> - struct clk *_clk;
>> - const char *name = qmp->cfg->clk_list[i];
>> -
>> - _clk = devm_clk_get(dev, name);
>> - if (IS_ERR(_clk)) {
>> - ret = PTR_ERR(_clk);
>> - if (ret != -EPROBE_DEFER)
>> - dev_err(dev, "failed to get %s clk, %d\n",
>> - name, ret);
>> - return ret;
>> - }
>> - qmp->clks[i] = _clk;
>> - }
>> + for (i = 0; i < num; i++)
>> + qmp->clks->id = qmp->cfg->clk_list[i];
> I think i missed this one while rebasing.
> We need to use index with this. Should be:
> qmp->clks[i]->id = qmp->cfg->clk_list[i];
>
Thanks, I will change this accordingly in next version.
> Regards
> Vivek
>
>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
