On Sat, 23 Dec 2017 00:43:14 +0300 Alexey Khoroshilov <[email protected]> wrote:
> vf610_nfc_probe() misses error handling of mtd_device_register(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <[email protected]> > --- > drivers/mtd/nand/vf610_nfc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c > index 8037d4b48a05..a4c181af74b3 100644 > --- a/drivers/mtd/nand/vf610_nfc.c > +++ b/drivers/mtd/nand/vf610_nfc.c > @@ -782,7 +782,10 @@ static int vf610_nfc_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, mtd); > > /* Register device in MTD */ > - return mtd_device_register(mtd, NULL, 0); > + err = mtd_device_register(mtd, NULL, 0); > + if (err) > + goto error; Nope, you're not entirely fixing the leak: nand_scan_tail() has to be undone with nand_cleanup(). > + return 0; > > error: > of_node_put(nand_get_flash_node(chip));
