On (12/28/17 15:48), Sergey Senozhatsky wrote: [..] > and I'm actually thinking about returning back the old vprintk_emit() > behavior > > vprintk_emit() > { > + preempt_disable(); > if (console_trylock()) > console_unlock(); > + preempt_enable(); > }
but am not going to. it's outside of printk_kthread scope. and, besides, not every CPU which is looping on console_unlock() came there via printk(). so by disabling preemption in console_unlock() we cover more cases. -ss