> -----Original Message----- > From: Andy Shevchenko [mailto:[email protected]] > Sent: Thursday, December 28, 2017 12:52 AM > To: Mehta, Sohil <[email protected]>; Joerg Roedel <[email protected]>; > Alex Williamson <[email protected]> > Cc: David Woodhouse <[email protected]>; Raj, Ashok > <[email protected]>; [email protected]; linux- > [email protected]; Jacob Pan <[email protected]>; Kammela, > Gayatri <[email protected]>; Shankar, Ravi V > <[email protected]>; Lu Baolu <[email protected]>; Yu, Fenghua > <[email protected]> > Subject: Re: [PATCH v5 2/5] iommu/vt-d: Add debugfs support to show context > internals > > On Thu, 2017-12-21 at 16:32 -0800, Sohil Mehta wrote: > > From: Gayatri Kammela <[email protected]> > > > > IOMMU internals states such as root and context can be exported to the > > userspace. > > > > Example of such dump in Kabylake: > > > v5: Change to a SPDX license tag > > Fix seq_printf formatting > > > > > > > +#define pr_fmt(fmt) "INTEL_IOMMU: " fmt > > +#include <linux/err.h> > > +#include <linux/io.h> > > +#include <linux/slab.h> > > +#include <linux/uaccess.h> > > +#include <linux/pm_runtime.h> > > +#include <linux/debugfs.h> > > +#include <linux/pci.h> > > +#include <linux/iommu.h> > > +#include <linux/intel-iommu.h> > > +#include <linux/intel-svm.h> > > +#include <linux/dmar.h> > > +#include <linux/spinlock.h> > > It might make sense to keep above ordered alphabetically. Sure Andy! > > > +static void root_tbl_entry_show(struct seq_file *m, struct > > intel_iommu *iommu, > > + u64 rtaddr_reg, bool ext, bool > > new_ext) > > +{ > > + int bus; > > + > > + seq_printf(m, "\nIOMMU %s: %2s Root Table Addr:%llx\n", > > iommu->name, > > + ext ? "Extended" : "", rtaddr_reg); > > Still leading '\n'... My bad, will correct it > > -- > Andy Shevchenko <[email protected]> > Intel Finland Oy
