On Wed, 2018-01-03 at 10:50 -0600, Pierre-Louis Bossart wrote: > Also make sure same dependencies are used everywhere (only last one > has SPI > in addition).
A nitpick: > config SND_SOC_INTEL_KBL_RT5663_MAX98927_MACH > tristate "ASoC Audio driver for KBL with RT5663 and MAX98927 > in I2S Mode" > - depends on X86_INTEL_LPSS && I2C > - select SND_SOC_INTEL_SST > + depends on MFD_INTEL_LPSS && I2C && ACPI > select SND_SOC_RT5663 > select SND_SOC_MAX98927 > select SND_SOC_DMIC > @@ -257,8 +256,7 @@ config SND_SOC_INTEL_KBL_RT5663_MAX98927_MACH > > config SND_SOC_INTEL_KBL_RT5663_RT5514_MAX98927_MACH > tristate "ASoC Audio driver for KBL with RT5663, RT5514 and > MAX98927 in I2S Mode" > - depends on X86_INTEL_LPSS && I2C && SPI > - select SND_SOC_INTEL_SST > + depends on MFD_INTEL_LPSS && I2C && SPI && ACPI Perhaps to split depends on SPI to separate line to follow pattern with the rest ? -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy
