On Mon, Jan 01, 2018 at 10:59:30PM +0100, Maciej S. Szmigiero wrote: > > +static void fsl_ssi_config_enable(struct fsl_ssi *ssi, bool tx)
> > + srcr = vals[tx].srcr; > > + stcr = vals[tx].stcr; > > + sier = vals[tx].sier; > > Implicit assumption here that RX == 0, TX == 1, as in the 03 patch. Could replace it with "bool dir" as well. Thanks for the review.