On Thu, 2018-01-04 at 09:56 -0800, Tim Chen wrote: > @@ -44,6 +47,7 @@ static inline void apm_bios_call_asm(u32 func, u32 ebx_in, > u32 ecx_in, > "=S" (*esi) > : "a" (func), "b" (ebx_in), "c" (ecx_in) > : "memory", "cc"); > + unprotected_formware_end();
Just an obvious typo (form/firm) but I thought I'd report it. > } > > static inline bool apm_bios_call_simple_asm(u32 func, u32 ebx_in, > @@ -52,6 +56,7 @@ static inline bool apm_bios_call_simple_asm(u32 func, u32 > ebx_in, > int cx, dx, si; > bool error; > > + unprotected_firmware_begin(); > /* > * N.B. We do NOT need a cld after the BIOS call > * because we always save and restore the flags. > @@ -68,6 +73,7 @@ static inline bool apm_bios_call_simple_asm(u32 func, u32 > ebx_in, > "=S" (si) > : "a" (func), "b" (ebx_in), "c" (ecx_in) > : "memory", "cc"); > + unprotected_formware_end(); > return error; > } Same here. -- Yves-Alexis
signature.asc
Description: This is a digitally signed message part
