On 1/4/2018 5:45 PM, Rob Herring wrote: > The hidma driver open codes populating address and IRQ resources from DT. > We have standard functions of_address_to_resource and of_irq_to_resource > for this, so use them instead. > > The DT binding states each child should have 2 addresses and 1 IRQ, so we > can simplify the logic and do a fixed size resource allocation. Using the > standard of_address_to_resource will also do any address translation which > was missing. > > Cc: Andy Gross <[email protected]> > Cc: David Brown <[email protected]> > Cc: Dan Williams <[email protected]> > Cc: Vinod Koul <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Rob Herring <[email protected]> > --- > drivers/dma/qcom/hidma_mgmt.c | 61 > +++++++++++-------------------------------- > 1 file changed, 15 insertions(+), 46 deletions(-)
Thanks, this certainly looks cleaner. Mine was mostly copy/paste from other examples. Reviewed-by: Sinan Kaya <[email protected]> -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
