Best Regards! Anson Huang
> -----Original Message----- > From: Fabio Estevam [mailto:[email protected]] > Sent: 2018-01-09 5:27 PM > To: Anson Huang <[email protected]> > Cc: Horia Geantă <[email protected]>; Aymen Sghaier > <[email protected]>; Herbert Xu <[email protected]>; > David S. Miller <[email protected]>; Rob Herring <[email protected]>; > Mark Rutland <[email protected]>; Shawn Guo <[email protected]>; > Sascha Hauer <[email protected]>; Fabio Estevam > <[email protected]>; Russell King - ARM Linux <[email protected]>; > Michael Turquette <[email protected]>; Stephen Boyd > <[email protected]>; Adriana Reus <[email protected]>; Stefan > Agner <[email protected]>; Dong Aisheng <[email protected]>; open > list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > <[email protected]>; [email protected]; linux- > [email protected]; moderated list:ARM/FREESCALE IMX / MXC ARM > ARCHITECTURE <[email protected]>; linux-kernel <linux- > [email protected]> > Subject: Re: [PATCH V2 2/2] ARM: dts: imx7s: add snvs rtc clock > > Hi Anson, > > On Tue, Jan 9, 2018 at 12:51 AM, Anson Huang <[email protected]> > wrote: > > > + - clocks > > + Usage: required if SNVS LP RTC requires explicit enablement of clocks > > + Value type: <prop_encoded-array> > > + Definition: A list of phandle and clock specifier pairs describing > > + the clocks required for enabling and disabling SNVS LP RTC. > > > It is a single clock that is used here, so it would be better to describe the > text as: > > Definition: A clock specifier describing the clock required for > enabling and > disabling SNVS LP RTC > > > + - clock-names > > + Usage: required if SNVS LP RTC requires explicit enablement of clocks > > + Value type: <string> > > + Definition: A list of clock name strings in the same order as the > > + clocks property. > > and here you must describe that the name should be "snvs-rtc": > > Definition: Clock name string should be "snvs-rtc". Agree, thanks. Will resend the patch. Anson.
