On Wed, 2018-01-10 at 12:34 +0300, Yury Norov wrote: > Hi Andy, > > On Tue, Jan 09, 2018 at 07:24:27PM +0200, Andy Shevchenko wrote: > > Explicitly test bitmap_zero() and bitmap_clear() functions.
> > + /* Known way to set all bits */ > > Nit: if you start your comments with capital, proceed that way till > the end. Right, I have to keep the original style. I'll check this. > I don't understand what patch #4 is doing in this series. At the first > glance, it may be applied separately. It fixes test failures found by patch 2 in the series. The idea is similar to TDD. > The rest is looking fine. For 1-3, > Reviewed-by: Yury Norov <yno...@caviumnetworks.com> Thanks. -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy
