Commit-ID:  13cb2d0f513cf35bf74484a392f745f9e9c5a3f2
Gitweb:     https://git.kernel.org/tip/13cb2d0f513cf35bf74484a392f745f9e9c5a3f2
Author:     Arnaldo Carvalho de Melo <a...@redhat.com>
AuthorDate: Tue, 2 Jan 2018 15:18:07 -0300
Committer:  Arnaldo Carvalho de Melo <a...@redhat.com>
CommitDate: Mon, 8 Jan 2018 11:11:56 -0300

perf test bpf: Use designated struct field initializers

To follow standard practice in the kernel sources, documenting the
initialization better and helping quickly finding the value for some
field in a struct with many entries.

Cc: Adrian Hunter <adrian.hun...@intel.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Wang Nan <wangn...@huawei.com>
Link: https://lkml.kernel.org/n/tip-syn3hz9hz7ukxlxbx5x6h...@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/tests/bpf.c | 59 +++++++++++++++++++++++---------------------------
 1 file changed, 27 insertions(+), 32 deletions(-)

diff --git a/tools/perf/tests/bpf.c b/tools/perf/tests/bpf.c
index 057c6b8..0512f1b 100644
--- a/tools/perf/tests/bpf.c
+++ b/tools/perf/tests/bpf.c
@@ -63,46 +63,41 @@ static struct {
        bool    pin;
 } bpf_testcase_table[] = {
        {
-               LLVM_TESTCASE_BASE,
-               "Basic BPF filtering",
-               "[basic_bpf_test]",
-               "fix 'perf test LLVM' first",
-               "load bpf object failed",
-               &epoll_wait_loop,
-               (NR_ITERS + 1) / 2,
-               false,
+               .prog_id          = LLVM_TESTCASE_BASE,
+               .desc             = "Basic BPF filtering",
+               .name             = "[basic_bpf_test]",
+               .msg_compile_fail = "fix 'perf test LLVM' first",
+               .msg_load_fail    = "load bpf object failed",
+               .target_func      = &epoll_wait_loop,
+               .expect_result    = (NR_ITERS + 1) / 2,
        },
        {
-               LLVM_TESTCASE_BASE,
-               "BPF pinning",
-               "[bpf_pinning]",
-               "fix kbuild first",
-               "check your vmlinux setting?",
-               &epoll_wait_loop,
-               (NR_ITERS + 1) / 2,
-               true,
+               .prog_id          = LLVM_TESTCASE_BASE,
+               .desc             = "BPF pinning",
+               .name             = "[bpf_pinning]",
+               .msg_compile_fail = "fix kbuild first",
+               .msg_load_fail    = "check your vmlinux setting?",
+               .target_func      = &epoll_wait_loop,
+               .expect_result    = (NR_ITERS + 1) / 2,
+               .pin              = true,
        },
 #ifdef HAVE_BPF_PROLOGUE
        {
-               LLVM_TESTCASE_BPF_PROLOGUE,
-               "BPF prologue generation",
-               "[bpf_prologue_test]",
-               "fix kbuild first",
-               "check your vmlinux setting?",
-               &llseek_loop,
-               (NR_ITERS + 1) / 4,
-               false,
+               .prog_id          = LLVM_TESTCASE_BPF_PROLOGUE,
+               .desc             = "BPF prologue generation",
+               .name             = "[bpf_prologue_test]",
+               .msg_compile_fail = "fix kbuild first",
+               .msg_load_fail    = "check your vmlinux setting?",
+               .target_func      = &llseek_loop,
+               .expect_result    = (NR_ITERS + 1) / 4,
        },
 #endif
        {
-               LLVM_TESTCASE_BPF_RELOCATION,
-               "BPF relocation checker",
-               "[bpf_relocation_test]",
-               "fix 'perf test LLVM' first",
-               "libbpf error when dealing with relocation",
-               NULL,
-               0,
-               false,
+               .prog_id          = LLVM_TESTCASE_BPF_RELOCATION,
+               .desc             = "BPF relocation checker",
+               .name             = "[bpf_relocation_test]",
+               .msg_compile_fail = "fix 'perf test LLVM' first",
+               .msg_load_fail    = "libbpf error when dealing with relocation",
        },
 };
 

Reply via email to