From: Taeung Song <treeze.tae...@gmail.com> Currently the FILTER_TRIVIAL_FALSE case has a missing break statement, if the trivial type is FALSE, it will also run into the TRUE case, and always be skipped as the TRUE statement will continue the loop on the inverse condition of the FALSE statement.
Link: http://lkml.kernel.org/r/1493218540-12296-1-git-send-email-treeze.tae...@gmail.com Reported-by: Namhyung Kim <namhy...@kernel.org> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> Signed-off-by: Steven Rostedt (VMware) <rost...@goodmis.org> --- tools/lib/traceevent/parse-filter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c index 2410afdcbcfe..2b9048f90bae 100644 --- a/tools/lib/traceevent/parse-filter.c +++ b/tools/lib/traceevent/parse-filter.c @@ -1631,6 +1631,7 @@ int pevent_filter_clear_trivial(struct event_filter *filter, case FILTER_TRIVIAL_FALSE: if (filter_type->filter->boolean.value) continue; + break; case FILTER_TRIVIAL_TRUE: if (!filter_type->filter->boolean.value) continue; -- 2.13.2
