On 12/01/2018 10:07 PM, Pavel Vazharov wrote:
> The actual sysfs io_error_limit value is left shifted IO_ERROR_SHIFT
> times before it is stored in the error_limit.
> This fixes the un-registering of the cache set when the io_errors reach
> the error_limit value.
>
> Signed-off-by: Pavel Vazharov <frea...@gmail.com>
> ---
> drivers/md/bcache/io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/io.c b/drivers/md/bcache/io.c
> index fac97ec..1ef6ae2 100644
> --- a/drivers/md/bcache/io.c
> +++ b/drivers/md/bcache/io.c
> @@ -93,7 +93,7 @@ void bch_count_io_errors(struct cache *ca, blk_status_t
> error, const char *m)
> &ca->io_errors);
> errors >>= IO_ERROR_SHIFT;
>
> - if (errors < ca->set->error_limit)
> + if (errors < (ca->set->error_limit >> IO_ERROR_SHIFT))
> pr_err("%s: IO error on %s, recovering",
> bdevname(ca->bdev, buf), m);
> else
>
Hi Pavel,
A similar fix is also in my device failure patch set, its name is,
bcache: set error_limit correctly
The difference is, I remove the bit shift of error_limit.
--
Coly Li
