3.18.91-rt98-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Thomas Gleixner <[email protected]>

Locking an rt mutex killable does not work because signal handling is
restricted to TASK_INTERRUPTIBLE.

Use signal_pending_state() unconditionaly.

Cc: [email protected]
Signed-off-by: Thomas Gleixner <[email protected]>
Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Signed-off-by: Steven Rostedt (VMware) <[email protected]>
---
 kernel/locking/rtmutex.c | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
index 8d950b4521fc..da35f7ef5324 100644
--- a/kernel/locking/rtmutex.c
+++ b/kernel/locking/rtmutex.c
@@ -1532,18 +1532,13 @@ __rt_mutex_slowlock(struct rt_mutex *lock, int state,
                if (try_to_take_rt_mutex(lock, current, waiter))
                        break;
 
-               /*
-                * TASK_INTERRUPTIBLE checks for signals and
-                * timeout. Ignored otherwise.
-                */
-               if (unlikely(state == TASK_INTERRUPTIBLE)) {
-                       /* Signal pending? */
-                       if (signal_pending(current))
-                               ret = -EINTR;
-                       if (timeout && !timeout->task)
-                               ret = -ETIMEDOUT;
-                       if (ret)
-                               break;
+               if (timeout && !timeout->task) {
+                       ret = -ETIMEDOUT;
+                       break;
+               }
+               if (signal_pending_state(state, current)) {
+                       ret = -EINTR;
+                       break;
                }
 
                if (ww_ctx && ww_ctx->acquired > 0) {
-- 
2.13.2


Reply via email to