On 01/18/2018 03:26 PM, Dmitry Safonov wrote:
> One can only use `make all` or `make <test_name>_<bitness>`
> as make targets.
> `make <test_name>` doesn't work as Ingo noticed:
> x86> make test_vsyscall
> gcc -O2 -g -std=gnu99 -pthread -Wall -no-pie test_vsyscall.c -o
> test_vsyscall
> /tmp/aBaoo3nb.o: In function `init_vdso':
> test_vsyscall.c:68: undefined reference to `dlopen'
> test_vsyscall.c:76: undefined reference to `dlsym'
> test_vsyscall.c:80: undefined reference to `dlsym'
> test_vsyscall.c:84: undefined reference to `dlsym'
> test_vsyscall.c:88: undefined reference to `dlsym'
> test_vsyscall.c:70: undefined reference to `dlopen'
> collect2: error: ld returned 1 exit status
> <builtin>: recipe for target 'test_vsyscall' failed
> make: *** [test_vsyscall] Error 1
>
> Makefile target substitution neither works :-/
>
> Generate .PHONY targets per-test and fix target substitution.
>
> Cc: Andy Lutomirski <l...@kernel.org>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Cc: Shuah Khan <sh...@kernel.org>
> Cc: Thomas Gleixner <t...@linutronix.de>
> Cc: linux-kselft...@vger.kernel.org
> Cc: x...@kernel.org
> Reported-by: Ingo Molnar <mi...@kernel.org>
> Signed-off-by: Dmitry Safonov <d...@arista.com>
> ---
> v2: collide two target lines $(1) and $(1)_{64,32}
>
> tools/testing/selftests/x86/Makefile | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
v2 is the right one.
Thanks for taking care of this. I plan to get this into 4.16-rc1
unless there is a dependency on x86 tree.
thanks,
-- Shuah
