On Tue, Jan 16, 2018 at 03:07:13PM -0800, Dmitry Torokhov wrote: Hi Dmitry,
> > On Sat, Jan 13, 2018 at 10:34:19AM +0800, Aaron Ma wrote: > > Will your patch go to stable kernel? > > If yes, that's fine. > > Hmm, it looks like we need this patch after all as we do have screwy > Lenovos with apparently 0x01 devices reporting 0 buttons. From > https://bugzilla.kernel.org/show_bug.cgi?id=196253 > > thinkpad_acpi: ThinkPad BIOS R0DET87W (1.87 ), EC unknown > thinkpad_acpi: Lenovo ThinkPad E470, model 20H1004SGE > > psmouse serio2: trackpoint: IBM TrackPoint firmware: 0x0e, buttons: 0/0 > > I'll ask them to try my patch and if it is indeed 0x01 device I'll apply > your patch. It is quite strange. In the past,for commit 293b915fd9be "Input: trackpoint - assume 3 buttons when buttons detection fails" there was success reported for lenovo e470 and I see the same success report in that bugzilla ticket. I can also report success on lenovo e570. But some seem to have problems, could it be that they are not including that commit in the kernel they are running ? Or did a bios upgrade change the behaviour ? It would be best when we have a confirmation from a e470 owner that without the proposed patch from Aaron the middle button does not work on his e470, and it works with it. Kind regards, Ulrik
