On Tue, Jan 23, 2018 at 04:25:48PM +0100, Peter Zijlstra wrote: > For some reason these were missing, I've not observed this patch > making a difference in the few code locations I checked, but this > makes sense. > > Cc: Jason Baron <jba...@akamai.com> > Signed-off-by: Peter Zijlstra (Intel) <pet...@infradead.org> > --- > include/linux/jump_label.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/include/linux/jump_label.h > +++ b/include/linux/jump_label.h > @@ -388,7 +388,7 @@ extern bool ____wrong_branch_error(void) > branch = !arch_static_branch_jump(&(x)->key, true); > \ > else > \ > branch = ____wrong_branch_error(); > \ > - branch; > \ > + likely(branch); > \ > }) > > #define static_branch_unlikely(x) > \ > @@ -400,7 +400,7 @@ extern bool ____wrong_branch_error(void) > branch = arch_static_branch(&(x)->key, false); > \ > else > \ > branch = ____wrong_branch_error(); > \ > - branch; > \ > + unlikely(branch); > \ > })
LOL, it is practically in the name already. :-) Reviewed-by: Borislav Petkov <b...@suse.de> -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.