Thanks for review Greg, > -----Original Message----- > From: Greg KH [mailto:[email protected]] > Sent: Tuesday, January 23, 2018 12:38 AM > To: Jolly Shah <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; Rajan Vaja > <[email protected]>; Jolly Shah <[email protected]> > Subject: Re: [PATCH v2 2/4] drivers: firmware: xilinx: Add ZynqMP firmware > driver > > On Wed, Jan 17, 2018 at 12:20:32PM -0800, Jolly Shah wrote: > > This patch is adding communication layer with firmware. > > Firmware driver provides an interface to firmware APIs. > > Interface APIs can be used by any driver to communicate to > > PMUFW(Platform Management Unit). All requests go through ATF. > > > > Signed-off-by: Jolly Shah <[email protected]> > > Signed-off-by: Rajan Vaja <[email protected]> > > --- > > arch/arm64/Kconfig.platforms | 1 + > > drivers/firmware/Kconfig | 1 + > > drivers/firmware/Makefile | 1 + > > drivers/firmware/xilinx/Kconfig | 4 + > > drivers/firmware/xilinx/Makefile | 4 + > > drivers/firmware/xilinx/zynqmp/Kconfig | 16 + > > drivers/firmware/xilinx/zynqmp/Makefile | 4 + > > drivers/firmware/xilinx/zynqmp/firmware.c | 987 > ++++++++++++++++++++++++ > > include/linux/firmware/xilinx/zynqmp/firmware.h | 570 ++++++++++++++ > > Why does this file need to be in include/linux/ at all? Shouldn't it just > live in the > driver-specific subdir? > > thanks, > > greg k-h
It is used by multiple drivers so can not live in driver specific subdir. Thanks, Jolly Shah
