On Sun, 20 May 2007, Robert P. J. Day wrote:

> i can do that as long as there's no way that those changes can (even
> theoretically) make a difference in the build.  in order to make sure
> this patch didn't break anything, i went with a straight cut-and-paste
> of the content to go into the new moduleinfo.h.
> 

__attribute_used__ is pointless outside of function definitions so the way 
it is currently written is incorrect.

> so while i agree that those changes shouldn't hurt, personally, i'd
> prefer to just put this patch through as is and come back later to do
> any tidying related to attribute rewording.
> 

__attribute_used__ is deprecated so it would be helpful to change it now 
instead of requiring a second patch.  It's better if new patches no longer 
use a deprecated attribute.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to