On Fri, Jan 19, 2018 at 10:47 PM, Hans de Goede <[email protected]> wrote: > Stop the work on suspend, otherwise it may run between our suspend method > running and the system suspending, possibly restarting the fan which > we've just stopped. > > Note we already requeue the work on resume, so that we get a fresh speed > at resume.
All three pushed to my reviewing and testing queue, thanks! > > Signed-off-by: Hans de Goede <[email protected]> > --- > drivers/platform/x86/gpd-pocket-fan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/gpd-pocket-fan.c > b/drivers/platform/x86/gpd-pocket-fan.c > index f7b4980c0aa6..6425c9b49caa 100644 > --- a/drivers/platform/x86/gpd-pocket-fan.c > +++ b/drivers/platform/x86/gpd-pocket-fan.c > @@ -177,6 +177,7 @@ static int gpd_pocket_fan_suspend(struct device *dev) > { > struct gpd_pocket_fan_data *fan = dev_get_drvdata(dev); > > + cancel_delayed_work_sync(&fan->work); > gpd_pocket_fan_set_speed(fan, gpd_pocket_fan_min_speed()); > return 0; > } > -- > 2.14.3 > -- With Best Regards, Andy Shevchenko
