Hi Andy, On 31 January 2018 at 00:48, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang <baolin.w...@linaro.org> wrote: >> The Spreadtrum SC9860 platform GPIO controller contains 16 groups and >> each group contains 16 GPIOs. Each GPIO can set input/output and has >> the interrupt capability. > >> +config GPIO_SPRD > >> + bool "Spreadtrum GPIO support" > > Either you have to put tristate here, or remove all redundant > module_*() and MODULE_*() macros.
I will remove module_*() and MODULE_*() macros in next version. Thanks for your comments. > > Other than that looks fine to me, FWIW: > Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> > -- Baolin.wang Best Regards
