Re: [PATCH v2 1/2] Add notrace to lib/ucmpdi2.c

[Matt Redfearn]

Hi

On 30/01/18 22:42, Antony Pavlov wrote:

From: Palmer Dabbelt <pal...@sifive.com>

As part of the MIPS conversion to use the generic GCC library routines,
Matt Redfearn discovered that I'd missed a notrace on __ucmpdi2().  This
patch rectifies the problem.

CC: Matt Redfearn <matt.redfe...@mips.com>
CC: Antony Pavlov <antonynpav...@gmail.com>
Signed-off-by: Palmer Dabbelt <pal...@sifive.com>

Looks good to me :-)
Reviewed-by: Matt Redfearn <amtt.redfe...@mips.com>

---
  lib/ucmpdi2.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ucmpdi2.c b/lib/ucmpdi2.c
index 25ca2d4c1e19..597998169a96 100644
--- a/lib/ucmpdi2.c
+++ b/lib/ucmpdi2.c
@@ -17,7 +17,7 @@
  #include <linux/module.h>
  #include <linux/libgcc.h>

-word_type __ucmpdi2(unsigned long long a, unsigned long long b)

+word_type notrace __ucmpdi2(unsigned long long a, unsigned long long b)
  {
        const DWunion au = {.ll = a};
        const DWunion bu = {.ll = b};