On Tue, 16 Jan 2018 19:45:05 PST (-0800), douly.f...@cn.fujitsu.com wrote:
The early_param() is only called during kernel initialization, So Linux marks the functions of it with __init macro to save memory.But it forgot to mark setup_pcie_rc_delay(). So, Make it __init as well. Cc: Bjorn Helgaas <bhelg...@google.com> Cc: Palmer Dabbelt <pal...@dabbelt.com> Cc: Chris Metcalf<cmetc...@mellanox.com> Cc: Andrew Morton <a...@linux-foundation.org> Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com> --- arch/tile/kernel/pci_gx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/tile/kernel/pci_gx.c b/arch/tile/kernel/pci_gx.c index 9aa238ac7b35..9a874e98b1cc 100644 --- a/arch/tile/kernel/pci_gx.c +++ b/arch/tile/kernel/pci_gx.c @@ -617,7 +617,7 @@ static void fixup_read_and_payload_sizes(struct pci_controller *controller) } } -static int setup_pcie_rc_delay(char *str) +static int __init setup_pcie_rc_delay(char *str) { unsigned long delay = 0; unsigned long trio_index;
Sorry this sat in my inbox for a while. I talked to Chris and he's not maintaining Linux any more. I maintain the RISC-V port, so I'm not actually sure how this got to me, but I don't mind collecting Tilera patches and submitting them to Linus. Note that I don't have any TileGx hardware or even a compiler, so it'd be a very low bar for maintenance.
If that's OK with everyone there then I can submit something that's more of a direct question to the mailing list.
