On Wed, 2018-02-07 at 12:43 +0100, Matthias Brugger wrote:
>
> On 02/06/2018 10:53 AM, sean.w...@mediatek.com wrote:
> > From: Sean Wang <sean.w...@mediatek.com>
> >
> > add nodes for the thermal controller and associated thermal zone using
> > CPU as the cooling device for each trip point. In addition, add a fixup
> > for thermal_calibration on nvmem should be 12 bytes as the minimal
> > requirement.
> >
> > Signed-off-by: Sean Wang <sean.w...@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 72
> > +++++++++++++++++++++++++++++++-
> > 1 file changed, 71 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > index e6dd4f6..6cf67dd 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > @@ -12,6 +12,7 @@
> > #include <dt-bindings/phy/phy.h>
> > #include <dt-bindings/power/mt7622-power.h>
> > #include <dt-bindings/reset/mt7622-reset.h>
> > +#include <dt-bindings/thermal/thermal.h>
> >
> > / {
> > compatible = "mediatek,mt7622";
> > @@ -75,6 +76,7 @@
> > <&apmixedsys CLK_APMIXED_MAIN_CORE_EN>;
> > clock-names = "cpu", "intermediate";
> > operating-points-v2 = <&cpu_opp_table>;
> > + #cooling-cells = <2>;
> > enable-method = "psci";
> > clock-frequency = <1300000000>;
> > };
> > @@ -119,6 +121,58 @@
> > };
> > };
> >
> > + thermal-zones {
> > + cpu_thermal: cpu-thermal {
> > + polling-delay-passive = <1000>;
> > + polling-delay = <1000>;
> > +
> > + thermal-sensors = <&thermal 0>;
> > +
> > + trips {
> > + cpu_passive: cpu-passive {
> > + temperature = <47000>;
> > + hysteresis = <2000>;
> > + type = "passive";
> > + };
> > +
> > + cpu_active: cpu-active {
> > + temperature = <67000>;
> > + hysteresis = <2000>;
> > + type = "active";
> > + };
> > +
> > + cpu_hot: cpu-hot {
> > + temperature = <87000>;
> > + hysteresis = <2000>;
> > + type = "hot";
> > + };
> > +
> > + cpu-crit {
> > + temperature = <107000>;
> > + hysteresis = <2000>;
> > + type = "critical";
> > + };
> > + };
> > +
> > + cooling-maps {
> > + map0 {
> > + trip = <&cpu_passive>;
> > + cooling-device = <&cpu0
> > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > + };
> > +
> > + map1 {
> > + trip = <&cpu_active>;
> > + cooling-device = <&cpu0
> > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > + };
> > +
> > + map2 {
> > + trip = <&cpu_hot>;
> > + cooling-device = <&cpu0
> > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > + };
> > + };
> > + };
> > + };
> > +
> > timer {
> > compatible = "arm,armv8-timer";
> > interrupt-parent = <&gic>;
> > @@ -201,7 +255,7 @@
> > #size-cells = <1>;
> >
> > thermal_calibration: calib@198 {
> > - reg = <0x198 0x8>;
> > + reg = <0x198 0xc>;
>
> Any reason why this is not part of patch 8/16?
>
There's no strong reason wanting me to do that. patch 8 has contained a
lot of nodes and patch 16 is present just in v2. So, I felt it should be
a little bit easy that people reviews those patches if they are put into
separate patches. But, It's still fine to make them into one in the next
version.
> Regards,
> Matthias
>
