Le 12/02/2018 à 09:48, Felipe Balbi a écrit :
Hi,
Christophe JAILLET <[email protected]> writes:
This serie aims to fix 2 issues. (path 2 & 4)
The 2nd patch fixes a memory leak. It uses devm_ function a simplify the
handling of the memory.
The 4th patch fixes a potential invalid pointer dereference.
The 2 other ones, are just clean-ups to remove useless code and add other
uses of devm_ function to simplify code.
I've left the request_irq/free_irq because I'm unsure of potential side
effects if some other resources are freed while an IRQ can still be
triggered. So I've preferred to leave it as-is.
Christophe JAILLET (4):
usb: gadget: fotg210-udc: Remove a useless
usb: gadget: fotg210-udc: Fix a memory leak
usb: gadget: fotg210-udc: Simplify code
usb: gadget: fotg210-udc: Fix a potential invalid pointer dereference
you should NEVER make fixes depend on cleanups. It should be the other
way around :-) First fixes, then cleanups. The reason is that fixes can
get accepted during -rc cycle, but cleanups must wait until the next
merge window.
Please fix up your patches, otherwise I'll have to apply the entire
series for v4.17
I agree with you. I will be more careful in the future.
However, I will not re-send an updated version. Development on this
driver does not seem to be very active. So the proposed fix (2/4) and
cleanups can wait a few more months.
Feel free to update yourself 2/4 (and eventually drop 1/4 completely to
avoid the time to re-work it) if you think that it worth it.
Best regards,
CJ
---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel
antivirus Avast.
https://www.avast.com/antivirus
